[Ryujinx] Address dotnet-format issues (#5395)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA1822 warnings

* Make dotnet format succeed in style mode

* Address dotnet format CA2208 warnings properly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Another rebase, another dotnet format run

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Second dotnet format pass

* Update src/Ryujinx/Modules/Updater/Updater.cs

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas and improve formatting

* Fix formatting and naming issues

* Rename nvStutterWorkaround to nvidiaStutterWorkaround

* Use using declarations and extend resource lifetimes

* Fix GTK issues

* Add formatting for generated files

* Add trailing commas

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

src/Ryujinx/Input/GTK3/GTK3Keyboard.cs

@@ -25,7 +25,7 @@ namespace Ryujinx.Input.GTK3
 
         private readonly GTK3KeyboardDriver _driver;
         private StandardKeyboardInputConfig _configuration;
-        private List<ButtonMappingEntry> _buttonsUserMapping;
+        private readonly List<ButtonMappingEntry> _buttonsUserMapping;
 
         public GTK3Keyboard(GTK3KeyboardDriver driver, string id, string name)
         {
@@ -48,6 +48,7 @@ namespace Ryujinx.Input.GTK3
         public void Dispose()
         {
             // No operations
+            GC.SuppressFinalize(this);
         }
 
         public KeyboardStateSnapshot GetKeyboardStateSnapshot()
@@ -87,7 +88,7 @@ namespace Ryujinx.Input.GTK3
                 stickX -= 1;
             }
 
-            OpenTK.Mathematics.Vector2 stick = new OpenTK.Mathematics.Vector2(stickX, stickY);
+            OpenTK.Mathematics.Vector2 stick = new(stickX, stickY);
 
             stick.NormalizeFast();
 

src/Ryujinx/Input/GTK3/GTK3KeyboardDriver.cs

@@ -9,7 +9,7 @@ namespace Ryujinx.Input.GTK3
     public class GTK3KeyboardDriver : IGamepadDriver
     {
         private readonly Widget _widget;
-        private HashSet<GtkKey> _pressedKeys;
+        private readonly HashSet<GtkKey> _pressedKeys;
 
         public GTK3KeyboardDriver(Widget widget)
         {
@@ -28,13 +28,13 @@ namespace Ryujinx.Input.GTK3
 
         public event Action<string> OnGamepadConnected
         {
-            add    { }
+            add { }
             remove { }
         }
 
         public event Action<string> OnGamepadDisconnected
         {
-            add    { }
+            add { }
             remove { }
         }
 
@@ -49,6 +49,7 @@ namespace Ryujinx.Input.GTK3
 
         public void Dispose()
         {
+            GC.SuppressFinalize(this);
             Dispose(true);
         }
 

src/Ryujinx/Input/GTK3/GTK3Mouse.cs

@@ -83,7 +83,8 @@ namespace Ryujinx.Input.GTK3
 
         public void Dispose()
         {
+            GC.SuppressFinalize(this);
             _driver = null;
         }
     }
-}
+}

src/Ryujinx/Input/GTK3/GTK3MouseDriver.cs

@@ -12,18 +12,18 @@ namespace Ryujinx.Input.GTK3
         private bool _isDisposed;
 
         public bool[] PressedButtons { get; }
-        
+
         public Vector2 CurrentPosition { get; private set; }
-        public Vector2 Scroll{ get; private set; }
+        public Vector2 Scroll { get; private set; }
 
         public GTK3MouseDriver(Widget parent)
         {
             _widget = parent;
 
-            _widget.MotionNotifyEvent  += Parent_MotionNotifyEvent;
-            _widget.ButtonPressEvent   += Parent_ButtonPressEvent;
+            _widget.MotionNotifyEvent += Parent_MotionNotifyEvent;
+            _widget.ButtonPressEvent += Parent_ButtonPressEvent;
             _widget.ButtonReleaseEvent += Parent_ButtonReleaseEvent;
-            _widget.ScrollEvent        += Parent_ScrollEvent;
+            _widget.ScrollEvent += Parent_ScrollEvent;
 
             PressedButtons = new bool[(int)MouseButton.Count];
         }
@@ -58,7 +58,7 @@ namespace Ryujinx.Input.GTK3
 
         public bool IsButtonPressed(MouseButton button)
         {
-            return PressedButtons[(int) button];
+            return PressedButtons[(int)button];
         }
 
         public Size GetClientSize()
@@ -67,21 +67,21 @@ namespace Ryujinx.Input.GTK3
         }
 
         public string DriverName => "GTK3";
-        
+
         public event Action<string> OnGamepadConnected
         {
-            add    { }
+            add { }
             remove { }
         }
 
         public event Action<string> OnGamepadDisconnected
         {
-            add    { }
+            add { }
             remove { }
         }
 
-        public ReadOnlySpan<string> GamepadsIds => new[] {"0"};
-        
+        public ReadOnlySpan<string> GamepadsIds => new[] { "0" };
+
         public IGamepad GetGamepad(string id)
         {
             return new GTK3Mouse(this);
@@ -94,6 +94,8 @@ namespace Ryujinx.Input.GTK3
                 return;
             }
 
+            GC.SuppressFinalize(this);
+
             _isDisposed = true;
 
             _widget.MotionNotifyEvent -= Parent_MotionNotifyEvent;
@@ -103,4 +105,4 @@ namespace Ryujinx.Input.GTK3
             _widget = null;
         }
     }
-}
+}